Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethink typing for FinStatementsBase considering invariant types #9

Open
nickderobertis opened this issue Dec 6, 2019 · 0 comments

Comments

@nickderobertis
Copy link
Owner

nickderobertis commented Dec 6, 2019

Was trying to set generic base types in the base class FinStatementsBase
and then in the subclasses, set them to the specific types. But this seems to not
work correctly with mutable collections of the types.

Currently I have set type ignore for all the subclass typing

See python/mypy#2984 (comment) for more details


This issue has been automatically created by todo-actions based on a TODO comment found in finstmt/findata/statementsbase.py:20. It will automatically be closed when the TODO comment is removed from the default branch (master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant