Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better matching of financial statement item names - Balance Sheet #3

Open
nickderobertis opened this issue Dec 6, 2019 · 0 comments

Comments

@nickderobertis
Copy link
Owner

nickderobertis commented Dec 6, 2019

Would be better to use regex instead of names list. Need to first add that infrastructure,
then apply it to the Balance Sheet config.


This issue has been automatically created by todo-actions based on a TODO comment found in finstmt/bs/config.py:4. It will automatically be closed when the TODO comment is removed from the default branch (master).

nickderobertis added a commit that referenced this issue Apr 11, 2023
* store income statement data points in dictionary

* Delete commit-checks.yml

* push checls

* income statement working from config file

* update inc statement to ret calcs using sym py

* changes to make IS work

* get working for BSheet

* set module name

* fixes for tests

* fixes for tests

* bs config fix

* undo changes

* undo

* remove blank line

* removing temp changes

* cleanup

* move nwc to namespace of dataclass

* force tests

* force tests

* ran dos2unix

* formatting

* nwc in config

* fix config

* remove calc item test

* config snapshot update. add nwc

* fixes for tests

* formatting

* formatting

* remove commented out code

* comments and cleanup

* Delete push-checks.yml

* feat: Introduce show_on_statement for ItemConfig (#1)

* Introduce show_on_statement

* typo

* update test_conf snapshot for show_on_statement

* cleanup

* formatting

* flake8 update

* feat: Reorder config list (#2)

* Introduce show_on_statement

* typo

* update test_conf snapshot for show_on_statement

* cleanup

* order inc config items to match expected output

* remove hardcoded ordering and order config files directly

* flake8 update

* update config snapshot for re-ordering

* update forecast snapshots for re-ordering

* formatting

* formatting

* feat: Move logic to generic statement class (#3)

* move logic to generic class

* fix class name

* update snapshots for generic class

* just and refactor

* remove BS and Inc Statement classes

* introduce statement item

* set return value type

* just

* casting

* just

* typo

* cleanup

* remove dataclass

* snapshots update

* just

* mypy

* cleanup

* snapshot update

* flake8

* just

* test for calculated item

* cleanup

* statement_item

* statement_item

* config_manager

* config_manager

* PeriodFinancialData

* typing

* remove dataclass references

* cleanup

* refactor

* bug

* bug fix

* bug

* config snapshot update

* forecast snapshot update

* just

* bug

* casting

* fixes

* fixes

* fixes and formatting

* test: Update snapshot formatter to accommodate dictionary output

* chore: Run strip

* fix: Raise an attribute error rather than key error for missing attribute in data base

* refactor: Change database -> period_data

* chore: Eliminate statement_cls for statements now that period data is not a base class

* chore: Minor cleanups and renaming in period data

* fix: Add public functions to period data __dir__

* chore: Comment cleanup

* chore: Remove some unused functions

* refactor: Clean up and comment verbosity changes

* chore: Remove a TODO comment that is no longer relevant

---------

Co-authored-by: Nick DeRobertis <whoopnip@gmail.com>
github-actions bot pushed a commit that referenced this issue Apr 12, 2023
## [1.3.0](v1.2.2...v1.3.0) (2023-04-12)

### Features

* Make financial statements easier to configure ([#100](#100)) ([1625657](1625657)), closes [#1](#1) [#2](#2) [#3](#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant