For sessionmanagement.client, require 0.1.0-dev2 or greater for sessionmanagement.proto #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Makes the sessionmanagement.client depend on sessionmanagement.proto 0.1.0-dev2 or greater. Prior, it was depending on 0.1.0-dev0 or greater.
Why should this Pull Request be merged?
As of #129, sessionmanagement.client needs sessionmanagement.proto to have an annotations module. See this line in _annotations.py:
from ni.measurementlink.sessionmanagement.v1.annotations import ...However, this was only added to sessionmanagement.proto in #134 which corresponds with sessionmanagement.proto 0.1.0-dev2. The dependency from sessionmanagement.client was never updated to require this version.
Therefore, there are scenarios where a user is updating their sessionmanagement.client dependency, but they won't get a new sessionmanagement.proto version as required.
What testing has been done?
Local 'poetry lock' and 'poetry install' of the sessionmanagement.client file to ensure it got the right version. PR checks.