add: Add annotation key constants for session management client #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds annotation key constants for session management client functionality, specifically to enable tracking of client machine details (hostname, username, IP address) for both registered and reserved sessions in the Manage Instrument Session UI.
Key changes:
- Introduces annotation constants for session client machine tracking
- Supports both "reserved" and "registered" session states
- Provides standardized keys for hostname, username, and IP address annotations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bkeryan
reviewed
Sep 10, 2025
...ssionmanagement.v1.proto/src/ni/measurementlink/sessionmanagement/v1/annotations/__init__.py
Show resolved
Hide resolved
jfriedri-ni
approved these changes
Sep 10, 2025
bkeryan
approved these changes
Sep 10, 2025
...ssionmanagement.v1.proto/src/ni/measurementlink/sessionmanagement/v1/annotations/__init__.py
Show resolved
Hide resolved
divakar-selvam07
deleted the
users/diva/add-session-annotation-constants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This Pull Request adds annotation key constants needed for the session management client to store client machine details as part of this Feature 3079033: View which machine has registered/reserved a session in the Manage Instrument Session UI.
Why should this Pull Request be merged?
As discussed here, placing these constants in the .proto package allows the client to use them directly.
What testing has been done?
ni.measurementlink.sessionmanagement.v1.proto