Fix tests with resource names when InstrumentStudio 2025Q3 is installed #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…io 2025Q3 or greater as well as older versions
Contributor
Test Results 52 files 52 suites 1h 13m 54s ⏱️ Results for commit dc98d70. ♻️ This comment has been updated with latest results. |
dixonjoel
requested review from
bkeryan,
csjall and
mshafer-NI
as code owners
bkeryan
approved these changes
Sep 9, 2025
dixonjoel
added a commit
that referenced
this pull request
Sep 30, 2025
…ed (#1225) * Add alternate session names so the tests can pass with InstrumentStudio 2025Q3 or greater as well as older versions * Fix ni-python-styleguide linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
I found that around 30 of the service tests fail when I have InstrumentStudio 2025Q3 installed locally. The problem was that the session management service started appending the driver name in front of the resource name for the session in Q3. For example, the session name became 'niDCPower-DCPower1/0' instead of just 'DCPower1/0'. The test machines are still using an older version of InstrumentStudio, so until we upgrade that, we have to allow for both versions.
Why should this Pull Request be merged?
Allows either version of the session name and tests can pass locally and on the test machines.
What testing has been done?
Ran the tests locally with InstrumentStudio 2025Q3. Test machines will validate older InstrumentStudio.