[WIP] feat: Populate Session Annotations with Client Machine details #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…into users/diva/populate-annotations-with-client-details
Contributor
Author
|
This PR is on hold until we get clarity on the recent changes done here. It can be reviewed once we mark it as "ready for review". |
…into users/diva/populate-annotations-with-client-details
Collaborator
|
The session management client have been moved to the ni-apis-python repo. All implementation and tests now reside in that repo and are included into measurement plugin sdk as a Python package dependency. |
Contributor
Author
|
Code changes have been moved here. Hence, abandoning this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This Pull Request implements support for the Feature 3079033: View which machine has registered/reserved a session in the Manage Instrument Session UI.
To enable this, we populate the newly introduced
annotationsparameter with client machine details during session reservation and registration. The following request types now include these annotations:ReserveSessionRequestRegisterSessionsRequestRegisterMultiplexerSessionsRequestReserveAllRegisteredSessionsRequestA new
_helpers.pyfile has been added to encapsulate helper methods for retrieving client machine details. These methods use:socket.gethostbynameto retrieve the IP addressWhy should this Pull Request be merged?
This change ensures that client machine details are sent via the Python SDK whenever a session is reserved or registered. These details are then displayed in InstrumentStudio's Manage Instrument Session UI, improving traceability and user context.
What testing has been done?
Manually verified the behavior using the Argo Installer.
TODO: Add testing if required.
Additional references: