Eliminate remaining grpc stubs for ni .proto files #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dixonjoel
changed the title
dixonjoel
changed the title
…ckages to be available
…ni-measurementlink-proto
dixonjoel
changed the title
dixonjoel
changed the title
dixonjoel
changed the title
Collaborator
|
Update CONTRIBUTING.md regarding generating stubs. Note that packages with proto stubs are pulled in as dependencies. |
csjall
approved these changes
Aug 22, 2025
bkeryan
approved these changes
Aug 22, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Consumes the rest of the packages from ni-apis-python. Remove all of the generated stubs from this repo.
New packages:
ni-grpcdevice-v1-protoni-measurementlink-measurement-v1-protoni-measurementlink-measurement-v2-protoni-measurementlink-pinmap-v1-protoni-measurementlink-protoni-measurementlink-sessionmanagement-v1-protoWhy should this Pull Request be merged?
Single source the stubs in the ni-apis-python repo.
What testing has been done?
CI / PR Tests ensure existing functionality