Consume ni.measurementlink.discovery.v1.proto package and remove _internal.stubs for discovery #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixonjoel
changed the title
Contributor
dixonjoel
changed the title
csjall
approved these changes
Aug 20, 2025
bkeryan
requested changes
Aug 20, 2025
...i_measurement_plugin_sdk_service/_internal/stubs/ni/measurementlink/discovery/v1/__init__.py
Show resolved
Hide resolved
bkeryan
requested changes
Aug 20, 2025
bkeryan
approved these changes
Aug 20, 2025
dixonjoel
deleted the
users/jdixon/consume-ni-measurementlink-discovery-v1-proto
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Pull in the new ni.measurementlink.discovery.v1.proto package and eliminate the copy of the grpc stubs in this repo.
Why should this Pull Request be merged?
Single source the generated grpc Python code.
What testing has been done?
Existing tests