Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apiVersion in Deployments and DaemonSets to apps/v1 #603

Merged
merged 2 commits into from
Jul 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployments/daemon-set/nginx-ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: nginx-ingress
Expand Down
2 changes: 1 addition & 1 deletion deployments/daemon-set/nginx-plus-ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: nginx-ingress
Expand Down
2 changes: 1 addition & 1 deletion deployments/deployment/nginx-ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx-ingress
Expand Down
2 changes: 1 addition & 1 deletion deployments/deployment/nginx-plus-ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx-ingress
Expand Down
2 changes: 1 addition & 1 deletion deployments/helm-chart/templates/controller-daemonset.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if eq .Values.controller.kind "daemonset" }}
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: {{ default (include "nginx-ingress.name" .) .Values.controller.name }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if eq .Values.controller.kind "deployment" }}
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ default (include "nginx-ingress.name" .) .Values.controller.name }}
Expand Down
6 changes: 3 additions & 3 deletions examples/complete-example/cafe.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: coffee
Expand Down Expand Up @@ -31,7 +31,7 @@ spec:
selector:
app: coffee
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: tea
Expand Down Expand Up @@ -63,4 +63,4 @@ spec:
protocol: TCP
name: http
selector:
app: tea
app: tea
2 changes: 1 addition & 1 deletion examples/mergeable-ingress-types/cafe-master.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ spec:
- cafe.example.com
secretName: cafe-secret
rules:
- host: cafe.example.com
- host: cafe.example.com
6 changes: 3 additions & 3 deletions examples/mergeable-ingress-types/cafe.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: coffee
Expand Down Expand Up @@ -31,7 +31,7 @@ spec:
selector:
app: coffee
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: tea
Expand Down Expand Up @@ -63,4 +63,4 @@ spec:
protocol: TCP
name: http
selector:
app: tea
app: tea
4 changes: 2 additions & 2 deletions examples/tcp-udp/dns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ data:
log
}
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: coredns
Expand Down Expand Up @@ -83,4 +83,4 @@ spec:
protocol: UDP
- name: dns-tcp
port: 53
protocol: TCP
protocol: TCP
8 changes: 4 additions & 4 deletions tests/data/common/app/advanced-routing/app.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend1
Expand Down Expand Up @@ -31,7 +31,7 @@ spec:
selector:
app: backend1
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend2
Expand Down Expand Up @@ -65,7 +65,7 @@ spec:
selector:
app: backend2
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend3
Expand Down Expand Up @@ -98,7 +98,7 @@ spec:
selector:
app: backend3
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend4
Expand Down
4 changes: 2 additions & 2 deletions tests/data/common/app/simple/app.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend1
Expand Down Expand Up @@ -31,7 +31,7 @@ spec:
selector:
app: backend1
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend2
Expand Down
6 changes: 3 additions & 3 deletions tests/data/common/app/split/app.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend1-v1
Expand Down Expand Up @@ -31,7 +31,7 @@ spec:
selector:
app: backend1-v1
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend1-v2
Expand Down Expand Up @@ -64,7 +64,7 @@ spec:
selector:
app: backend1-v2
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend2
Expand Down
2 changes: 1 addition & 1 deletion tests/data/common/backend1.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: backend1
Expand Down
17 changes: 10 additions & 7 deletions tests/suite/fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from kubernetes import config, client
from kubernetes.client import CoreV1Api, ExtensionsV1beta1Api, RbacAuthorizationV1beta1Api, CustomObjectsApi, \
ApiextensionsV1beta1Api
ApiextensionsV1beta1Api, AppsV1Api

from suite.custom_resources_utils import create_crds_from_yaml, delete_crd, create_virtual_server_from_yaml, \
delete_virtual_server
Expand Down Expand Up @@ -36,11 +36,13 @@ class KubeApis:
"""
def __init__(self, v1: CoreV1Api,
extensions_v1_beta1: ExtensionsV1beta1Api,
apps_v1_api: AppsV1Api,
rbac_v1_beta1: RbacAuthorizationV1beta1Api,
api_extensions_v1_beta1: ApiextensionsV1beta1Api,
custom_objects: CustomObjectsApi):
self.v1 = v1
self.extensions_v1_beta1 = extensions_v1_beta1
self.apps_v1_api = apps_v1_api
self.rbac_v1_beta1 = rbac_v1_beta1
self.api_extensions_v1_beta1 = api_extensions_v1_beta1
self.custom_objects = custom_objects
Expand Down Expand Up @@ -117,11 +119,11 @@ def ingress_controller(cli_arguments, kube_apis, ingress_controller_prerequisite
"""
namespace = ingress_controller_prerequisites.namespace
print("------------------------- Create IC -----------------------------------")
name = create_ingress_controller(kube_apis.v1, kube_apis.extensions_v1_beta1, cli_arguments, namespace)
name = create_ingress_controller(kube_apis.v1, kube_apis.apps_v1_api, cli_arguments, namespace)

def fin():
print("Delete IC:")
delete_ingress_controller(kube_apis.extensions_v1_beta1, name, cli_arguments['deployment-type'], namespace)
delete_ingress_controller(kube_apis.apps_v1_api, name, cli_arguments['deployment-type'], namespace)

request.addfinalizer(fin)

Expand Down Expand Up @@ -193,10 +195,11 @@ def kube_apis(cli_arguments) -> KubeApis:
config.load_kube_config(config_file=kubeconfig, context=context_name, persist_config=False)
v1 = client.CoreV1Api()
extensions_v1_beta1 = client.ExtensionsV1beta1Api()
apps_v1_api = client.AppsV1Api()
rbac_v1_beta1 = client.RbacAuthorizationV1beta1Api()
api_extensions_v1_beta1 = client.ApiextensionsV1beta1Api()
custom_objects = client.CustomObjectsApi()
return KubeApis(v1, extensions_v1_beta1, rbac_v1_beta1, api_extensions_v1_beta1, custom_objects)
return KubeApis(v1, extensions_v1_beta1, apps_v1_api, rbac_v1_beta1, api_extensions_v1_beta1, custom_objects)


@pytest.fixture(scope="session", autouse=True)
Expand Down Expand Up @@ -271,7 +274,7 @@ def crd_ingress_controller(cli_arguments, kube_apis, ingress_controller_prerequi
crd_names = create_crds_from_yaml(kube_apis.api_extensions_v1_beta1,
f"{DEPLOYMENTS}/common/custom-resource-definitions.yaml")
print("------------------------- Create IC -----------------------------------")
name = create_ingress_controller(kube_apis.v1, kube_apis.extensions_v1_beta1, cli_arguments, namespace,
name = create_ingress_controller(kube_apis.v1, kube_apis.apps_v1_api, cli_arguments, namespace,
request.param.get('extra_args', None))
ensure_connection_to_public_endpoint(ingress_controller_endpoint.public_ip,
ingress_controller_endpoint.port,
Expand All @@ -282,7 +285,7 @@ def fin():
print("Remove the CRD:")
delete_crd(kube_apis.api_extensions_v1_beta1, crd_name)
print("Remove the IC:")
delete_ingress_controller(kube_apis.extensions_v1_beta1, name, cli_arguments['deployment-type'], namespace)
delete_ingress_controller(kube_apis.apps_v1_api, name, cli_arguments['deployment-type'], namespace)
print("Restore the ClusterRole:")
patch_rbac(kube_apis.rbac_v1_beta1, f"{DEPLOYMENTS}/rbac/rbac.yaml")

Expand Down Expand Up @@ -339,7 +342,7 @@ def virtual_server_setup(request, kube_apis, crd_ingress_controller, ingress_con
def fin():
print("Clean up Virtual Server Example:")
delete_virtual_server(kube_apis.custom_objects, vs_name, test_namespace)
delete_common_app(kube_apis.v1, kube_apis.extensions_v1_beta1, common_app, test_namespace)
delete_common_app(kube_apis.v1, kube_apis.apps_v1_api, common_app, test_namespace)

request.addfinalizer(fin)

Expand Down
Loading