Update apiVersion in Deployments and DaemonSets to apps/v1 #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorcanMcVeigh
force-pushed
the
update-resource-versions
branch
from
c2811e8
to
d2a498e
Compare
Dean-Coakley
approved these changes
Jul 2, 2019
pleshakov
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
@LorcanMcVeigh
before merging, please squash your 4 commits into a single one
LorcanMcVeigh
force-pushed
the
update-resource-versions
branch
from
bb93ef3
to
81a149a
Compare
Rulox
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
lgtm!
@LorcanMcVeigh remember to Rebase and Merge , also be sure CI is passing before merging (is red right now)
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the apiVersion in the daemonSet & deployment manifest and the daemonSet & deployment helm template