-
Notifications
You must be signed in to change notification settings - Fork 126
Functional Tests for SnippetsFilter #2664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
401e19f
to
40e5852
Compare
921c376
to
6786ab5
Compare
6786ab5
to
37c82a1
Compare
37c82a1
to
214db1c
Compare
07d133f
to
990cc19
Compare
990cc19
to
9052743
Compare
b1f7cc1
to
96fb278
Compare
sjberman
reviewed
Oct 8, 2024
96fb278
to
b9f57c4
Compare
sjberman
reviewed
Oct 8, 2024
ee3965d
to
0590085
Compare
bjee19
reviewed
Oct 8, 2024
0590085
to
141f927
Compare
bjee19
reviewed
Oct 8, 2024
bjee19
reviewed
Oct 8, 2024
sjberman
reviewed
Oct 8, 2024
bjee19
reviewed
Oct 8, 2024
141f927
to
f8f86a5
Compare
f8f86a5
to
503439e
Compare
pre-commit.ci autofix |
bjee19
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once lint checks are fixed and include directive checks are added to the http and main files
5883fb0
to
bd00631
Compare
pre-commit.ci autofix |
8165ef7
to
cae7ae7
Compare
40e5852
to
4626043
Compare
1925948
to
ef471f2
Compare
d9ddbec
to
e4ad18c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: User wants to have functional tests for SnippetsFilter.
Solution: Adds functional tests for SnippetsFilter
Test Case Scenarios
Accepted
Accepted
Testing: Run tests manually multiple times.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #2371
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.