Skip to content

Functional Tests for SnippetsFilter #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Oct 8, 2024

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: User wants to have functional tests for SnippetsFilter.

Solution: Adds functional tests for SnippetsFilter

Test Case Scenarios

  1. Tests SnippetsFilter are correctly applied to HTTPRoute
  • Verify SnippetsFilter Status is Accepted
  • Verify traffic is working for the uri configured.
  • Verify directives are placed in the right context
  1. Tests SnippetsFilter are correctly applied to GRPCRoute
  • Verify SnippetsFilter Status is Accepted
  • Verify traffic is working for the uri configured.
  • Verify directives are placed in the right context
  1. Tests invalid SnippetsFilter attached to routes throws an error
  • When SnippetsFilter has directives which already exists in the nginx.conf.
  • When SnippetsFilter has directives in the wrong context.

Testing: Run tests manually multiple times.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #2371

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@salonichf5 salonichf5 requested review from a team as code owners October 8, 2024 18:23
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file helm-chart Relates to helm chart labels Oct 8, 2024
@sjberman sjberman force-pushed the feature/snippets-filter branch from 401e19f to 40e5852 Compare October 8, 2024 19:09
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from 921c376 to 6786ab5 Compare October 8, 2024 19:22
@github-actions github-actions bot added tests Pull requests that update tests and removed dependencies Pull requests that update a dependency file labels Oct 8, 2024
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from 6786ab5 to 37c82a1 Compare October 8, 2024 19:26
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 8, 2024
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from 37c82a1 to 214db1c Compare October 8, 2024 19:29
@github-actions github-actions bot removed the helm-chart Relates to helm chart label Oct 8, 2024
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch 2 times, most recently from 07d133f to 990cc19 Compare October 8, 2024 19:59
@github-actions github-actions bot added the helm-chart Relates to helm chart label Oct 8, 2024
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from 990cc19 to 9052743 Compare October 8, 2024 20:01
@github-actions github-actions bot removed the helm-chart Relates to helm chart label Oct 8, 2024
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch 2 times, most recently from b1f7cc1 to 96fb278 Compare October 8, 2024 20:15
@github-actions github-actions bot added the helm-chart Relates to helm chart label Oct 8, 2024
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from 96fb278 to b9f57c4 Compare October 8, 2024 20:21
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from ee3965d to 0590085 Compare October 8, 2024 21:30
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from 0590085 to 141f927 Compare October 8, 2024 21:33
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from 141f927 to f8f86a5 Compare October 8, 2024 22:43
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 8, 2024
@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch from f8f86a5 to 503439e Compare October 8, 2024 22:45
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 8, 2024
@salonichf5
Copy link
Contributor Author

pre-commit.ci autofix

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once lint checks are fixed and include directive checks are added to the http and main files

@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch 2 times, most recently from 5883fb0 to bd00631 Compare October 9, 2024 00:29
@salonichf5
Copy link
Contributor Author

pre-commit.ci autofix

@salonichf5 salonichf5 force-pushed the tests/snippets-functional branch 3 times, most recently from 8165ef7 to cae7ae7 Compare October 9, 2024 07:06
@sjberman sjberman force-pushed the feature/snippets-filter branch from 40e5852 to 4626043 Compare October 9, 2024 14:14
@sjberman sjberman force-pushed the tests/snippets-functional branch from 1925948 to ef471f2 Compare October 9, 2024 14:15
@sjberman sjberman force-pushed the tests/snippets-functional branch from d9ddbec to e4ad18c Compare October 9, 2024 16:13
@github-actions github-actions bot removed the helm-chart Relates to helm chart label Oct 9, 2024
@sjberman sjberman merged commit 7f37bcb into feature/snippets-filter Oct 9, 2024
35 checks passed
@sjberman sjberman deleted the tests/snippets-functional branch October 9, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants