Skip to content

Commit 921c376

Browse files
committed
rebase to main
1 parent ebb5286 commit 921c376

File tree

4 files changed

+4
-27
lines changed

4 files changed

+4
-27
lines changed

internal/mode/static/nginx/config/generator.go

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -107,22 +107,6 @@ func (g GeneratorImpl) Generate(conf dataplane.Configuration) []file.File {
107107
return files
108108
}
109109

110-
func (g GeneratorImpl) getExecuteFuncs(generator policies.Generator) []executeFunc {
111-
return []executeFunc{
112-
executeMainConfig,
113-
executeBaseHTTPConfig,
114-
g.newExecuteServersFunc(generator),
115-
g.executeUpstreams,
116-
executeSplitClients,
117-
executeMaps,
118-
executeTelemetry,
119-
g.executeStreamServers,
120-
g.executeStreamUpstreams,
121-
executeStreamMaps,
122-
executeVersion,
123-
}
124-
}
125-
126110
func generatePEM(id dataplane.SSLKeyPairID, cert []byte, key []byte) file.File {
127111
c := make([]byte, 0, len(cert)+len(key)+1)
128112
c = append(c, cert...)
@@ -179,6 +163,7 @@ func (g GeneratorImpl) runExecuteFuncs(
179163

180164
func (g GeneratorImpl) getExecuteFuncs(generator policies.Generator) []executeFunc {
181165
return []executeFunc{
166+
executeMainConfig,
182167
executeBaseHTTPConfig,
183168
g.newExecuteServersFunc(generator),
184169
g.executeUpstreams,

internal/mode/static/nginx/config/generator_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,20 +175,12 @@ func TestGenerate(t *testing.T) {
175175
expString := "{}"
176176
g.Expect(string(files[2].Content)).To(Equal(expString))
177177

178-
<<<<<<< HEAD
179-
g.Expect(files[3].Path).To(Equal("/etc/nginx/main-includes/main.conf"))
180-
181-
mainCfg := string(files[3].Content)
182-
g.Expect(mainCfg).To(ContainSubstring("load_module modules/ngx_otel_module.so;"))
183-
g.Expect(mainCfg).To(ContainSubstring("error_log stderr debug;"))
184-
=======
185178
// snippet include files
186179
// content is not checked in this test.
187180
g.Expect(files[3].Path).To(Equal("/etc/nginx/includes/http_snippet1.conf"))
188181
g.Expect(files[4].Path).To(Equal("/etc/nginx/includes/http_snippet2.conf"))
189182
g.Expect(files[5].Path).To(Equal("/etc/nginx/includes/main_snippet1.conf"))
190183
g.Expect(files[6].Path).To(Equal("/etc/nginx/includes/main_snippet2.conf"))
191-
>>>>>>> 401e19f7 (Apply configuration of SnippetsFilters to NGINX (#2604))
192184

193185
g.Expect(files[7].Path).To(Equal("/etc/nginx/main-includes/main.conf"))
194186
mainConfStr := string(files[7].Content)

internal/mode/static/nginx/config/main_config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func executeMainConfig(conf dataplane.Configuration) []executeResult {
2525

2626
results := make([]executeResult, 0, len(includes)+1)
2727
results = append(results, executeResult{
28-
dest: mainIncludeFile,
28+
dest: mainIncludesConfigFile,
2929
data: helpers.MustExecuteTemplate(mainConfigTemplate, mc),
3030
})
3131
results = append(results, createIncludeExecuteResults(includes)...)

internal/mode/static/nginx/config/main_config_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func TestExecuteMainConfig_Telemetry(t *testing.T) {
4646

4747
res := executeMainConfig(test.conf)
4848
g.Expect(res).To(HaveLen(1))
49-
g.Expect(res[0].dest).To(Equal(mainIncludeFile))
49+
g.Expect(res[0].dest).To(Equal(mainIncludesConfigFile))
5050
if test.expLoadModuleDirective {
5151
g.Expect(res[0].data).To(ContainSubstring(loadModuleDirective))
5252
} else {
@@ -105,5 +105,5 @@ func TestExecuteMainConfig_Snippets(t *testing.T) {
105105
g.Expect(res[2].dest).To(Equal("/etc/nginx/includes/snippet3.conf"))
106106
g.Expect(string(res[2].data)).To(ContainSubstring("contents3"))
107107

108-
g.Expect(res[3].dest).To(Equal(mainIncludeFile))
108+
g.Expect(res[3].dest).To(Equal(mainIncludesConfigFile))
109109
}

0 commit comments

Comments
 (0)