-
Notifications
You must be signed in to change notification settings - Fork 2k
Add SNI to NIC JWT Policy #7993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7993 +/- ##
==========================================
+ Coverage 52.95% 52.96% +0.01%
==========================================
Files 90 90
Lines 21729 21749 +20
==========================================
+ Hits 11506 11519 +13
- Misses 9746 9752 +6
- Partials 477 478 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8e60efa
to
76d3797
Compare
5a23849
to
7c2c3e4
Compare
Token string `json:"token"` | ||
JwksURI string `json:"jwksURI"` | ||
KeyCache string `json:"keyCache"` | ||
SNIEnabled bool `json:"sniEnabled"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haywoodsh can we add same description here in the keys as the PR in docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay working on it. I guess the review for the docs will be done in this PR then.
JwksPort: "443", | ||
JwksPath: "/spec-keys", | ||
JwksSNIEnabled: true, | ||
JwksSNIName: "sni.idp.spec.example.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haywoodsh same test at the route level line#2371
Proposed changes
Closes #7427
Adds the ability to specify SNI related options for jwt policies.
There are two configuration options:
sniEnabled
, which controls the value of theproxy_ssl_server_name
nginx directive, andsniName, which controls the value of the
proxy_ssl_name` nginx directiveSpecifying
sniName
without SNI being enabled will result in an error.Documentation PR: nginx/documentation#795
Checklist
Before creating a PR, run through this checklist and mark each as complete.