Skip to content

feat: Add sni related config options to jwt policy #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: nic-release-5.2
Choose a base branch
from

Conversation

javorszky
Copy link
Contributor

@javorszky javorszky commented Jul 8, 2025

Proposed changes

Adds two new configuration options to the NIC / jwt policy options: sniEnabled and sniName.

Functionality PR for the underlying code is nginx/kubernetes-ingress#7993.

⚠️ Does not need to go live until the release that will have 7993 in it (5.2.0 probably)!

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@javorszky javorszky requested a review from a team as a code owner July 8, 2025 13:01
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nic NGINX Ingress Controller related issues labels Jul 8, 2025
Copy link

github-actions bot commented Jul 8, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/795/

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM: if these are intended for an upcoming release, we could probably set-up the new release branch so that can be the target instead of main.

Otherwise, I'm somewhat inclined to keep this in draft just in case someone merges prematurely.

@javorszky javorszky marked this pull request as draft July 8, 2025 15:32
@javorszky
Copy link
Contributor Author

Otherwise, I'm somewhat inclined to keep this in draft just in case someone merges prematurely.

Excellent suggestion, thank you. I need to figure out how to not forget about this draft PR though 🤔

@ADubhlaoich ADubhlaoich changed the base branch from main to nic-release-5.2 July 10, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nic NGINX Ingress Controller related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants