Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: add a panel around diff previews when updating #3246

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 24, 2024

fixes #3239

@jfy133
Copy link
Member

jfy133 commented Oct 24, 2024

Do you have a screnshot as to what it looks like?

@mashehu
Copy link
Contributor Author

mashehu commented Oct 24, 2024

👉🏻 #3239 (comment)

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it would also be nice to have a marker between each group of files too, e.g. set of files per module.

My reasoning is I need to make sure e.g. I look at the combination of a main.nf and meta to make sure I understand what channel modifications I have to make in the pipeline

@mashehu
Copy link
Contributor Author

mashehu commented Oct 24, 2024

okay, a bit more difficult, but I will give it a try

@jfy133
Copy link
Member

jfy133 commented Oct 24, 2024

okay, a bit more difficult, but I will give it a try

Can just be a straight line across the whole width of screen printed before the question of 'updated X/y/z module'?

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (d59ac3f) to head (29f6765).
Report is 12 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu
Copy link
Contributor Author

mashehu commented Oct 24, 2024

Screenshot 2024-10-24 at 18 21 16

better?

@mashehu
Copy link
Contributor Author

mashehu commented Oct 24, 2024

alternative 2
Screenshot 2024-10-24 at 18 24 59

@jfy133
Copy link
Member

jfy133 commented Oct 25, 2024

Yes I think that will do for now (would need to try to test in the wild a few times ).

The blue border is nice but I find it's a hit harder to read the name of the module

But no strong feeling on the colour

@jfy133 jfy133 self-requested a review October 25, 2024 03:42
@mashehu
Copy link
Contributor Author

mashehu commented Oct 25, 2024

how about this then
Screenshot 2024-10-25 at 10 42 21

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mashehu mashehu merged commit eb4c237 into nf-core:dev Oct 25, 2024
84 checks passed
@mashehu mashehu deleted the add-diff-seperator branch October 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants