Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download: Bugfix for AttributeError: 'ContainerError' object has no attribute 'absoluteURI' #2543

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

MatthiasZepper
Copy link
Member

Unrelated to the bugfix, I have also made a small change to the documentation, since I recently had some odd issues with that one myself.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@MatthiasZepper MatthiasZepper changed the base branch from master to dev November 27, 2023 16:27
@nf-core nf-core deleted a comment from github-actions bot Nov 27, 2023
@MatthiasZepper MatthiasZepper added this to the 2.11 milestone Nov 27, 2023
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind writing a test for this?

@MatthiasZepper
Copy link
Member Author

Do you mind writing a test for this?

Frankly? Yes.

There is already a test for the ContainerError that I wrote, but it simply is a very fragile piece of code, because it depends on non-standard responses from different container registries and has to deal with whatever weirdly specified container URIs that somehow made it through PR review and linting and were eventually released in a pipeline revision.

Feel free to add more test cases there, but on macOS the test does not run locally due to the lack of Singularity.

@mashehu
Copy link
Contributor

mashehu commented Dec 9, 2023

test_component tests are currently failing due to transitioning to aws in #2550. wil merge anyway

@mashehu mashehu merged commit c007a5e into nf-core:dev Dec 9, 2023
18 of 20 checks passed
@MatthiasZepper MatthiasZepper deleted the Download_bugfix_absoluteURI branch February 21, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants