Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
  • Loading branch information
MatthiasZepper and mashehu authored Oct 25, 2024
1 parent 3d953fe commit 32a7e6b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions nf_core/pipelines/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -995,15 +995,15 @@ def prioritize_direct_download(self, container_list: List[str]) -> List[str]:
A regex that matches http, r"^$|^http" could thus be used to prioritize the Docker URIs over http Downloads
We also need to handle a special case: The https:// Singularity downloads from Seqera Containers all end in 'data', although
they are not equivalent:
they are not equivalent, e.g.:
'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/63/6397750e9730a3fbcc5b4c43f14bd141c64c723fd7dad80e47921a68a7c3cd21/data'
'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/c2/c262fc09eca59edb5a724080eeceb00fb06396f510aefb229c2d2c6897e63975/data'
"""
d: dict[str, str] = {}
seqera_containers: list[str] = []
all_others: list[str] = []
d: Dict[str, str] = {}
seqera_containers: List[str] = []
all_others: List[str] = []

for c in container_list:
if bool(re.search(r"/data$", c)):
Expand Down

0 comments on commit 32a7e6b

Please sign in to comment.