fix(gtffilter): add support for non-Ensembl GTF files. - #1890
Open
kanishkanandhkumar wants to merge 1 commit into
Open
fix(gtffilter): add support for non-Ensembl GTF files.#1890kanishkanandhkumar wants to merge 1 commit into
kanishkanandhkumar wants to merge 1 commit into
Conversation
pinin4fjords
requested changes
Jul 21, 2026
Member
There was a problem hiding this comment.
@kanishkanandhkumar - sorry, but this is an nf-core module, so you'll need to propose this change in the nf-core/modules repo, get it merged there, then do nf-core modules update ... for this module in your rnaseq copy before you PR here.
Be sure you've joined the nf-core Slack, you can ask for review on module updates there in the request-review channel there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR updates
modules/nf-core/custom/gtffilter/templates/gtffilter.pyto support non-Ensembl GTF annotations (e.g., NCBI/RefSeq, GENCODE, FlyBase, TAIR).Summary of fixes:
#without triggering column-count validation errors.transcript_idmatching: Replaced strict Ensembl regex (transcript_id "...") with a flexible regex pattern to match unquoted, single-quoted, and=-separated attributes (e.g.,transcript_id=TX123).generetention: Ensured top-levelgenefeature entries are preserved even when they lack atranscript_idattribute.tab_delimited()validation so.gtf.gzcompressed inputs are properly uncompressed during checking rather than throwing column count errors.Type of Change
Verification
nf-core modules lint custom/gtffilterlocally (Passed 45/45 tests).