Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nextstrain automation rules and configs to ingest/build-configs #50

Merged

Conversation

j23414
Copy link
Contributor

@j23414 j23414 commented Mar 6, 2024

Description of proposed changes

Move automation rules to a "ingest/build-configs/automation" directory. Attempt to follow the template at

https://github.com/nextstrain/pathogen-repo-guide/tree/f825132e441a672586ec1748af4cdb149669f7c3/ingest/build-configs/nextstrain-automation

Related issue(s)

Checklist

  • Checks pass

@j23414 j23414 linked an issue Mar 6, 2024 that may be closed by this pull request
@j23414 j23414 marked this pull request as draft March 6, 2024 23:13
@j23414
Copy link
Contributor Author

j23414 commented Mar 6, 2024

This is a draft because I'm not confident about the changes here: 168949e

@j23414 j23414 force-pushed the 44-move-nextstrain-automation-rulesconfigs-to-ingestbuild-configs branch from 168949e to 1dde069 Compare March 9, 2024 00:36
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Any reason this still needs to be a draft PR? I think it's good to merge as long as the nextstrain-automation build runs as expected.

ingest/README.md Outdated Show resolved Hide resolved
j23414 and others added 4 commits March 15, 2024 09:55
Since we are moving to a different system, remove the slack and trigger
rebuild rules from the ingest directory.
Since "defaults/config.yaml" is always loaded by default, update the upload instructions

Co-authored-by: Jover Lee <joverlee521@gmail.com>
@j23414 j23414 force-pushed the 44-move-nextstrain-automation-rulesconfigs-to-ingestbuild-configs branch from 662afd0 to b45b7b9 Compare March 15, 2024 14:00
@j23414 j23414 marked this pull request as ready for review March 15, 2024 14:05
@j23414 j23414 changed the title Draft: Move nextstrain automation rules and configs to ingest/build-configs Move nextstrain automation rules and configs to ingest/build-configs Mar 15, 2024
@j23414 j23414 merged commit 7b3fe1a into main Mar 16, 2024
32 checks passed
@j23414 j23414 deleted the 44-move-nextstrain-automation-rulesconfigs-to-ingestbuild-configs branch March 16, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Nextstrain "automation rules/configs" to "ingest/build-configs"
2 participants