Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in h5n1-cattle-outbreak segment 'pa' #961

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix typo in h5n1-cattle-outbreak segment 'pa' #961

merged 1 commit into from
Jul 29, 2024
+1 −1

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jul 29, 2024 •
edited
Loading

Follow-up to #957 (comment)

Checklist

@victorlin victorlin self-assigned this Jul 29, 2024
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-victorlin--ygossm July 29, 2024 19:22 Inactive
joverlee521
joverlee521 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@victorlin
Copy link
Member Author

Check if changes affect the resource index JSON revision

data/manifest_core.json is changed, but next.nextstrain.org already has the correct link to pa builds. I think this is because #956 got merged after the new segment builds were already available in S3. So no need to bump with this PR.

@victorlin victorlin mentioned this pull request Jul 29, 2024
Merged
3 tasks
@victorlin victorlin merged commit 1579ae7 into master Jul 29, 2024
6 checks passed
@victorlin victorlin deleted the victorlin/fix-manifest branch July 29, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joverlee521 joverlee521 joverlee521 approved these changes

Assignees

@victorlin victorlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorlin @joverlee521 @nextstrain-bot