fix: Use relative paths to dav root #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
fix/filename-relative-to-davroot
branch
from
fe29d2b
to
1463c3f
Compare
juliushaertl
force-pushed
the
fix/filename-relative-to-davroot
branch
from
1463c3f
to
c2ec4ad
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
fix/filename-relative-to-davroot
branch
from
c2ec4ad
to
6912165
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
approved these changes
Aug 13, 2024
You mean when calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@susnux After #2392 and #2414 the filename attribute is still different from before. Before we used to have the relative path based on the user home or public share, how it actually includes the files/userId/ dav root.
My quick fix proposal would be to change the root that the dav client uses so the path it returns for filename is again relative to that root.
We could otherwise of course adjust apps that make use of that path, but I think the path relative to the root is more useful then the full dav path.
Before the refactor: /MyFolder/test.odt
After the refactor: /files/admin/MyFolder/test.odt
After this PR: /MyFolder/test.odt
Test CI runs for text, richdocuments: