Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure correct DAV path is used (and use DAV v2 on public shares #2414

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 12, 2024

Two things are important:

  1. Make sure to correctly built DAV paths (we really need to clean up - but best with NC31).
  2. Simply use @nextcloud/files DAV path on public shares as we can use DAV v2 now.

Screen recording

Logged in

Bildschirmaufnahme_20240812_185734.webm

Public share

Bildschirmaufnahme_20240812_190406.webm

…res)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working regression Regression of a previous working feature 3. to review Waiting for reviews labels Aug 12, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 12, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit bd99947 into master Aug 12, 2024
30 checks passed
@susnux susnux deleted the fix/regressions branch August 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants