Bump to v5.2 and require at least NC 25 #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
approved these changes
Mar 3, 2023
blizzz
force-pushed
the
td/noid/min-require-25
branch
from
be3aa11 to
e5254fd
Compare
blizzz
force-pushed
the
td/noid/min-require-25
branch
from
e5254fd to
0c26181
Compare
|
manual rebase |
|
Codesniffer and drone are not happy. |
Drone is actually happy, but 26 and master fail because of incompatibilites with the OS of the test image. There'S #712 on going to fix this, but we're not there yet. 25 is the canaray for so long :( |
|
cannot reproduce the cs issue locally :-/ |
eh, can, with PHP7.4 instead of 8 🤯 |
blizzz
force-pushed
the
td/noid/min-require-25
branch
from
fded531 to
3d4271c
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
td/noid/min-require-25
branch
2 times, most recently
from
0fdaa61 to
aa11909
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
td/noid/min-require-25
branch
from
aa11909 to
5fea0ae
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
juliusknorr
force-pushed
the
td/noid/min-require-25
branch
2 times, most recently
from
e81be0b to
8054c89
Compare
juliusknorr
approved these changes
May 15, 2023
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
td/noid/min-require-25
branch
from
8054c89 to
bb2667b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #698 as bumping php-jwt would not be backwards compatible with older NC/GSS versions.
Additional stable26 testing added in #704