Skip to content

[stable25] Treat newlines as linebreaks when pasting as plaintext #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2022
Merged

[stable25] Treat newlines as linebreaks when pasting as plaintext #3625

merged 2 commits into from
Dec 31, 2022

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Dec 31, 2022

Until now, every newline was transformed into a paragraph break when pasting plaintext.

Instead, newlines will be treated as linebreaks. Two newlines in a row will be treated as paragraph break.

Fixes: #3598

Manual backport of #3623

Signed-off-by: Jonas jonas@freesources.org

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo-
Treat newlines as linebreaks when pasting as plaintext
c7e7dda 
Until now, every newline was transformed into a paragraph break when
pasting plaintext.

Instead, newlines will be treated as linebreaks. Two newlines in a row
will be treated as paragraph break.

Fixes: #3598

Manual backport of #3623

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added this to the Nextcloud 25.0.3 milestone Dec 31, 2022
@mejo-
Copy link
Member Author

mejo- commented Dec 31, 2022

/compile

@nextcloud-command
Compile assets
bdb3b36 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress
Copy link

cypress bot commented Dec 31, 2022


Test summary

99 • 0 • 0 • 0 • Flakiness 2

Run details
Project Text
Status Passed
Commit a73275c ℹ️
Started Dec 31, 2022 11:38 AM
Ended Dec 31, 2022 11:44 AM
Duration 05:21 💡
OS Linux Ubuntu - 22.04
Browser Electron 106

View run in Cypress Dashboard ➡️

Flakiness

mentions.spec.js 1 Flakiness
1 Test mentioning users > Type @ and see the user list
sections.spec.js 1 Flakiness
1 Content Sections > Heading anchors > Anchor scrolls into view

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@max-nextcloud max-nextcloud changed the title Treat newlines as linebreaks when pasting as plaintext [stable25] Treat newlines as linebreaks when pasting as plaintext Dec 31, 2022
max-nextcloud
max-nextcloud approved these changes Dec 31, 2022
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.

@max-nextcloud max-nextcloud merged commit b040f67 into stable25 Dec 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/3623/stable25 branch December 31, 2022 18:19
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
Merged
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@susnux susnux Awaiting requested review from susnux

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 25.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@mejo- @max-nextcloud @nextcloud-command