Treat newlines as linebreaks when pasting as plaintext #3623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, every newline was transformed into a paragraph break when pasting plaintext. Instead, newlines will be treated as linebreaks. Two newlines in a row will be treated as paragraph break. Fixes: #3598 Signed-off-by: Jonas <jonas@freesources.org>
We distinguish between <Ctrl>-<V> and <Ctrl>-<Shift>-<V> when pasting text to decide whether the input should be treated as markdown or plaintext. On Linux systems, it's also possible to paste text with a middle mouse click. Let's consider there as well whether the <Shift> key is down. Sidenote: with shift key down, the handleClick and handleClickOn events are not called, so we have to go through the DOM events directly. Signed-off-by: Jonas <jonas@freesources.org>
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
max-nextcloud
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Until now, every newline was transformed into a paragraph break when pasting plaintext.
Instead, newlines will be treated as linebreaks. Two newlines in a row will be treated as paragraph break.
Fixes: #3598
The second commit in this PR adds a change to catch shiftKey when pasting with middle click.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)