Skip to content

[stable21] Use file.path to track more accurately EditorWrapper instances #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2022
Merged

[stable21] Use file.path to track more accurately EditorWrapper instances #2152

merged 1 commit into from
Feb 17, 2022

Conversation

@julien-nc
Copy link
Member

Backport of #2145

@julien-nc julien-nc added bug Something isn't working 3. to review labels Feb 3, 2022
@julien-nc julien-nc added this to the Nextcloud 21.0.8 milestone Feb 3, 2022
@julien-nc
Copy link
Member Author

/compile amend

@nextcloud-command nextcloud-command force-pushed the fix/stable21/rich_workspace_when_deplacing_readme branch from 51db587 to c46e9f7 Compare February 3, 2022 14:22
@max-nextcloud
Copy link
Collaborator

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/stable21/rich_workspace_when_deplacing_readme branch from c46e9f7 to 6099032 Compare February 16, 2022 20:06
@max-nextcloud
Copy link
Collaborator

/rebase

max-nextcloud
max-nextcloud previously requested changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking since this may have unintended consequences.

Say i edit a file and you rename it in the meantime... What should happen? I think it's a feature and not a bug, that the editing keeps working and i now edit the file with the new name.

@max-nextcloud max-nextcloud dismissed their stale review February 17, 2022 04:56

tried it on stable23 and now it works better than before.

@max-nextcloud
Use file.path to track more accurately EditorWrapper instances
6864795 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud force-pushed the fix/stable21/rich_workspace_when_deplacing_readme branch from 6099032 to 6864795 Compare February 17, 2022 04:58
@max-nextcloud max-nextcloud merged commit 7a56dbf into stable21 Feb 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/stable21/rich_workspace_when_deplacing_readme branch February 17, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo- mejo- mejo- approved these changes

@artonge artonge artonge approved these changes

@max-nextcloud max-nextcloud max-nextcloud left review comments

Assignees

No one assigned

Labels

3. to review bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@julien-nc @max-nextcloud @mejo- @artonge @blizzz