Use file.path to track EditorWrapper instances more accurately #2145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
fix/rich_workspace_when_deplacing_readme
branch
from
9c9278c to
1a5c791
Compare
artonge
changed the title
artonge
requested review from
a team,
julien-nc and
max-nextcloud
and removed request for
a team
julien-nc
force-pushed
the
fix/rich_workspace_when_deplacing_readme
branch
from
1a5c791 to
e9ec411
Compare
|
Rebased and recompiled |
|
/compile amend |
nextcloud-command
force-pushed
the
fix/rich_workspace_when_deplacing_readme
branch
from
e9ec411 to
9af74d1
Compare
|
/rebase |
This fixes rich workspace loading when moving a Readme.md into a folder and navigating into that folder. The file.id stay the same, so no new components are created and RichWorkspace stays in an ready=false state because EditorWrapper never emit a new ready event. Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
mejo-
force-pushed
the
fix/rich_workspace_when_deplacing_readme
branch
from
9af74d1 to
a74c263
Compare
|
Sorry rebased, compiled and force-pushed another time. |
mejo-
approved these changes
Feb 3, 2022
delete-merged-branch
bot
deleted the
fix/rich_workspace_when_deplacing_readme
branch
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rich workspace loading when moving a
Readme.mdinto a folder and navigating into that folder.The
file.idstays the same, so no new components are created and RichWorkspace stays in aready=falsestate because EditorWrapper never emits a new ready event.