-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move app to Vue.js #194
Move app to Vue.js #194
Conversation
Quick look and feedbacks :)
You can also take a look at the contacts migration, we set up very strict coding rules and config files to make sure e have the cleanest app possible: https://github.com/nextcloud/contacts/tree/vue 🤗 Questions:
|
Thanks for the feedback. 😃
I will have a look.
Means, the vue/js files should be in
I would like to get rid of it as well. It currently is used to compile the sprite file and concat the scss files. I will have a look how to do this with webpack only. |
Yes :)
Well, you can create a single tasks.scss app which import all the other scss, the server will then compile a single file ;) |
I improved the webpack configuration, basically copied your webpack config from contacts. I couldn't get rid of gulp completely yet, but it might be possible by using a plain npm module. I still have to adjust the makefile, though. |
Maybe it's just required for your setup then :) |
eb9de51
to
8991c01
Compare
I could get rid of Gulp, |
2a6d625
to
73230d0
Compare
c1fb01f
to
fa8dbcb
Compare
Moved to #194 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skjnldsv @georgehrke Is this a good solution to filter VTODO calendars or should this be in the CDAV library?
Congrats!!! 🎉 |
Many thanks for this! can't wait to try it out |
Wow! I just received v0.10.0 and I can now use my tasks tab again. Thank you and nice work! |
Works like a charm. Thank you! |
thank you, it works very well. Just two little points that I'll address in other issues but performance is so much better |
Hello everyone, this modification is absolute awesome :-), thank you for making my live better with it. This small difference makes what is added in an OpenTasks app as a subtask visible as text on the nextcloud tasks subpage, on the other hand inserting a Markdown formatted subtask / internal task on nextcloud tasks subpage produces a non-formatted string with square brackets, that is not understood as subtask and not rendered correctly by OpenTasks. I am not sure if I should request any modification here or on OpenTasks's project page; if I knew what and where to modify I could test it immediately on my NC installation. I tought it might be somewhere in tasks.js file, but it looks too complicated for me. |
@michalroxorpl Could you please create a separate issue for this? Maybe we can adjust the configuration of the Markdown plugin we use to also recognize tasks without the leading dash. |
@michalroxorpl I just had a quick look at the markdown-it documentation and it seems a list item has to start with So while all of this
will be a task item, omitting the leading |
Fixes #2510 This logic was introduced in #194 and further discussed in #2523. The app-navigation is now closing when clicking in content-area if a user uses a mobile device. The app-sidebar doesn't close when clicking inside the app-navigation or content-area anymore, similar to how the Calendar app handles it. Signed-off-by: Jakob Linskeseder <jakob@linskeseder.com>
I started migrating the app to Vue.js now.
Basically nothing is functional at the moment, but the build is working and the store and the router are in place and operative. Furthermore, all templates are rudimentary moved to vue (the angular attributes are still present as a memory aid) and the collections are loaded from the server.
Any feedback is appreciated, especially on:
I guess @skjnldsv and @georgehrke might want to have a look ;)
Things left to do for feature parity with the angular version:
readOnly
state from the server@babel/polyfill is loaded more than once on this page. This is probably not desirable/intended and may have consequences if different versions of the polyfills are applied sequentially. If you do need to load the polyfill more than once, use @babel/polyfill/noConflict instead to bypass the warning.
Array.filter()
Things to improve over the previous version: