fix: don't close sidebar when clicking outside #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2510 This logic was introduced in #194 and further discussed in #2523. The app-navigation is now closing when clicking in content-area if a user uses a mobile device. The app-sidebar doesn't close when clicking inside the app-navigation or content-area anymore, similar to how the Calendar app handles it. Signed-off-by: Jakob Linskeseder <jakob@linskeseder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2510
This logic (closing sidebar when clicking outside) was introduced in #194.
I don't know if this was done deliberately or by accident, but I agree with #2510: the app-sidebar should stay open when clicking outside (like it is done in other apps).
With this change, the app-sidebar will only change if the a different route is pushed.
Since this is change is similar to nextcloud-libraries/nextcloud-vue/issues/1070, I also changed how the app-navigation on mobile behaves.
As far as I understand (and how I as a user feel), the app-navigation should close when clicking in the content-area (if on a mobile device).