-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show name for bridged messages #5667
Conversation
c2feb1e
to
6a62ef1
Compare
b5f43ea
to
39adb2c
Compare
I guess we have to wait until that is merged? |
Yup. It'd be noop if merged right now |
noop in terms of "works as before" or in terms of "breaks and doesn't do anything anymore" |
Works as before |
39adb2c
to
d5a79a4
Compare
d5a79a4
to
d553423
Compare
If everything seems fine on this side, we could merge now. It |
Maybe you can ping them again? |
42wim/matterbridge#1506 is now merged so this feature should now work with the executables here: https://github.com/42wim/matterbridge/actions/runs/953056470. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from my POV, but I guess we should wait for 22 to go out as the mobile apps need a patch too
Would have been nice to get it into 22 but we're lacking in time, I suppose |
Android patch at nextcloud/talk-android#1355 |
Can you rebase @gary-kim |
Signed-off-by: Gary Kim <gary@garykim.dev>
Signed-off-by: Gary Kim <gary@garykim.dev>
Signed-off-by: Gary Kim <gary@garykim.dev>
Signed-off-by: Gary Kim <gary@garykim.dev>
Signed-off-by: Gary Kim <gary@garykim.dev>
Signed-off-by: Gary Kim <gary@garykim.dev>
d553423
to
e736c8a
Compare
Requires 42wim/matterbridge#1506.Now merged!The way the current iteration works is that messages received from the
bridge-bot
user is labeled as Actor Typebridged
. Actor Typebridged
messages store the message author name in the Actor Id field inoc_comments
. When serving to the frontend, this is slightly changed to put what is in Actor Id into Actor Display Name and set the Actor Id tobridge-bot
(the reason it was done this way was to simplify the changes that would need to be made to clients).As far as clients have to care, the only difference is the addition of the Actor Type
bridged
and that forbridged
messages, the Actor Display Name can be different for every message.Screenshots