-
Notifications
You must be signed in to change notification settings - Fork 511
feat(openmetrics): Add basic call metrics #16834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2da4b8e to
0a496b8
Compare
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I'd call it sessions, as many users with the same user id count as multiple and cause load like multiple, but it might be a confusing detail.
The unit however has to change to sessions or participants
|
I would then also change participants -> sessions in spreed/lib/Command/Monitor/HasActiveCalls.php Lines 47 to 54 in 0a496b8
|
|
I'd not change the command to not break scripting done with it |
0a496b8 to
321fb84
Compare
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
321fb84 to
973bc6a
Compare
https://prometheus.io/docs/specs/om/open_metrics_spec/#unit Needs to be fixed. Server has currently the same issue, it's only a SHOULD in version 2.0.0, but we export 1.0.0 and there it's a MUST. |
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
f9b8827 to
52600b9
Compare
|
Fixed in last commit |
|
/backport to stable33 |
Add some basic talk metrics to the OpenMetrics endpoint:
openmetricselement server#57766🏁 Checklist
docs/has been updated or is not required