Skip to content

Conversation

@SystemKeeper
Copy link
Contributor

When apps specify multiple exporters, the ExportManager crashes:

Nachricht: Illegal offset type in isset or empty
Datei: /var/www/html/lib/private/OpenMetrics/ExporterManager.php
Zeile: 67

#0 /var/www/html/core/Controller/OpenMetricsController.php(80): OC\OpenMetrics\ExporterManager->export()
#1 /var/www/html/lib/public/AppFramework/Http/StreamTraversableResponse.php(46): OC\Core\Controller\OpenMetricsController->generate()
#2 /var/www/html/lib/private/AppFramework/App.php(210): OCP\AppFramework\Http\StreamTraversableResponse->callback(Object(OC\AppFramework\Http\Output))
#3 /var/www/html/lib/private/Route/Router.php(321): OC\AppFramework\App::main('OC\\Core\\Control...', 'export', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
#4 /var/www/html/lib/base.php(1125): OC\Route\Router->match('/metrics')
#5 /var/www/html/index.php(25): OC::handleRequest()
#6 {main}

Not really sure how to easily add a test for this.

Checklist

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper added this to the Nextcloud 34 milestone Jan 23, 2026
@SystemKeeper SystemKeeper requested a review from Altahrim January 23, 2026 16:40
@SystemKeeper SystemKeeper requested a review from a team as a code owner January 23, 2026 16:40
@SystemKeeper SystemKeeper requested review from come-nc, leftybournes and provokateurin and removed request for a team January 23, 2026 16:40
@SystemKeeper
Copy link
Contributor Author

/backport to stable33

@provokateurin provokateurin merged commit 739b018 into master Jan 23, 2026
188 of 197 checks passed
@provokateurin provokateurin deleted the fix/noid/openmetrics-multiple-app-exporters branch January 23, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants