Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SunOS (tested against OmniOS) #461

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pstumpe
Copy link

@pstumpe pstumpe commented May 30, 2023

requires "top" package to be installed for parsing memory/swap info (cmd "pkg install top")
Signed-off-by: pstumpe github@stumpe.ws

@joshtrichards
Copy link
Member

joshtrichards commented Jun 6, 2023

Is your implementation at all related to the one linked to from #263 by @dertuxmalwieder (they haven't submitted a PR, but did reference the issue in their fork's commit so I saw it pop up over there).

dertuxmalwieder@ba979bf

EDIT: Nevermind! Thank you for your PR. There was a prior PR, but it was built on an older implementation of serverinfo. I overlooked the full history.

@dertuxmalwieder
Copy link

I wish that my first approach would have been merged. ;-)

@pstumpe
Copy link
Author

pstumpe commented Jun 6, 2023

Actually I took a look at the PRs from @dertuxmalwieder and tried to fix a few problems / errors in the code together with some small changes (e.g. as to show ZFS filesystems instead of actual discs).

@kesselb
Copy link
Collaborator

kesselb commented Jun 6, 2023

Thanks for your pull request 👍

Please add tests for your implementation. You may use the tests I wrote for the other SunOS / OmniOS as a starting point: https://github.com/nextcloud/serverinfo/compare/feat/sun-os

@kesselb kesselb marked this pull request as draft June 28, 2023 13:18
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@skjnldsv skjnldsv removed this from the Nextcloud 29.0.1 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants