Skip to content

chore: bypass slow password validation in integration tests #58610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
icewind1991 wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −1
Draft

chore: bypass slow password validation in integration tests #58610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
874cee8
chore: bypass slow password validation in integration tests
icewind1991 Feb 27, 2026
4191197
chore: enable apcu local caching for integration tests
icewind1991 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/integration-sqlite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,20 @@ jobs:
path: apps/activity
ref: ${{ matrix.activity-versions }}

- name: Checkout Security-Softening app
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
repository: icewind1991/security_softening
path: apps/security_softening

- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, ldap, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, ldap, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite, apcu
coverage: none
ini-file: development
env:
Expand All @@ -146,6 +153,8 @@ jobs:
mkdir data
./occ maintenance:install --verbose ${{ contains(matrix.test-suite,'ldap') && '--data-dir=/dev/shm/nc_int' || '' }} --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
./occ config:system:set hashing_default_password --value=true --type=boolean
Copy link
Member

@nickvergessen nickvergessen Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be moved to

server/build/integration/run.sh

Lines 26 to 39 in 65135bb

if [ "$INSTALLED" == "true" ]; then
# Disable appstore to avoid spamming from CI
$OCC config:system:set appstoreenabled --value=false --type=boolean
# Disable bruteforce protection because the integration tests do trigger them
$OCC config:system:set auth.bruteforce.protection.enabled --value false --type bool
# Disable rate limit protection because the integration tests do trigger them
$OCC config:system:set ratelimit.protection.enabled --value false --type bool
# Allow local remote urls otherwise we can not share
$OCC config:system:set allow_local_remote_servers --value true --type bool
# Allow self signed certificates
$OCC config:system:set sharing.federation.allowSelfSignedCertificates --value true --type bool
# Allow creating users with dummy passwords
$OCC app:disable password_policy
else

so that people running it locally benefit as well

./occ app:enable security_softening
./occ config:system:set memcache.local --value='\OC\Memcache\APCu'

- name: Configure caching
if: ${{ contains(matrix.test-suite,'ldap') }}
Expand Down
Loading