chore: bypass slow password validation in integration tests#58610
chore: bypass slow password validation in integration tests#58610icewind1991 wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Did you also do: locally when testing your improving? Otherwise that would explain the non-existing difference on CI :P |
| @@ -146,6 +153,7 @@ jobs: | |||
| mkdir data | |||
| ./occ maintenance:install --verbose ${{ contains(matrix.test-suite,'ldap') && '--data-dir=/dev/shm/nc_int' || '' }} --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin | |||
| ./occ config:system:set hashing_default_password --value=true --type=boolean | |||
There was a problem hiding this comment.
I guess this should be moved to
server/build/integration/run.sh
Lines 26 to 39 in 65135bb
so that people running it locally benefit as well
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
It seems to have just been a case of ACPu not being enabled before, the performance improvements seem to work now: 8m/15m for sharees_feautures/sharing_features compared to 13m/24m before The various failures are probably a side effect of the added caching, will look into those |
From early testing it looks like we spend 50%-60% of the runtime of integration tests doing password validation 🙈
This enables the security_softening, which bypasses this by caching the password validation.