Skip to content

fix(l10n): Don't fallback from 3-letter languages to 2-letter #55803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

fix(l10n): Don't fallback from 3-letter languages to 2-letter #55803

merged 1 commit into from
Oct 16, 2025

Conversation

@nickvergessen
Copy link
Member

Fix #55274

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 33 milestone Oct 16, 2025
@nickvergessen nickvergessen self-assigned this Oct 16, 2025
@nickvergessen nickvergessen requested a review from a team as a code owner October 16, 2025 09:30
@nickvergessen nickvergessen requested review from Altahrim, leftybournes and salmart-dev and removed request for a team October 16, 2025 09:30
@nickvergessen nickvergessen added 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters labels Oct 16, 2025
@nickvergessen
Copy link
Member Author

/backport to stable32

@nickvergessen
Copy link
Member Author

/backport to stable31

come-nc
come-nc reviewed Oct 16, 2025
View reviewed changes
@nickvergessen
fix(l10n): Don't fallback from 3-letter languages to 2-letter
9e4ac50 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/55274/dont-fallback-from-3letter-languages-to-2letter branch from 0e78008 to 9e4ac50 Compare October 16, 2025 09:46
salmart-dev
salmart-dev approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@salmart-dev salmart-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to import the incomplete translations and test this locally?

@nickvergessen
Copy link
Member Author

Is there any way to import the incomplete translations and test this locally?

It's not "incomplete", kab can basically never exist in Nextcloud as we only support lower ISO 2-letter languages.

You can test it easily by:

  1. Settings your browser to
image
  1. Open the login page
  2. Check if it's fully german
Before (half english half gergian) After (full german)
image image

@nickvergessen nickvergessen merged commit 6fc190e into master Oct 16, 2025
180 of 187 checks passed
@nickvergessen nickvergessen deleted the bugfix/55274/dont-fallback-from-3letter-languages-to-2letter branch October 16, 2025 11:43
This was referenced Oct 16, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salmart-dev salmart-dev salmart-dev approved these changes

@come-nc come-nc come-nc approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: language/translations (l10n/i18n) Localization and translation matters

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: mix georgian and kabyle language

4 participants

@nickvergessen @salmart-dev @come-nc