-
-
Couldn't load subscription status.
- Fork 4.6k
fix(comments): expand long comment on click #55179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
please always add the proper milestone and labels on PRs |
|
/backport to stable32 |
|
/backport to stable31 |
Ah right, it's been a while since I made a server PR, thanks for the reminder. Although next time, I think it would be helpful to include those items in the checklist in the PR template. For neuro-accessibility reasons, required items should be explicitly rather than implicitly said. |
This is a temporary fix that only applies while the server is still using Vue 2.x (or `@nextcloud/vue` 8.x). Once migrated to Vue 3.x, this fix may be reverted. Signed-off-by: Edward Ly <contact@edward.ly>
59701bc to
1b067aa
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/55179/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1b067aab 0e79e6f1
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55179/stable31Error: Failed to push branch backport/55179/stable31: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable31 |
Summary
This is a temporary fix that only applies while the server is still using Vue 2.x (or
@nextcloud/vue8.x), in which case no events other than those specific to theNcRichTextcomponent are emitted.TODO
@nextcloud/vue9.x), this fix may be reverted.Checklist