Skip to content

Conversation

@edward-ly
Copy link
Contributor

@edward-ly edward-ly commented Sep 18, 2025

Summary

This is a temporary fix that only applies while the server is still using Vue 2.x (or @nextcloud/vue 8.x), in which case no events other than those specific to the NcRichText component are emitted.

Before After
Screenshot 2025-09-18 at 15-52-34 All files - Files - Nextcloud Screenshot 2025-09-18 at 15-53-57 All files - Files - Nextcloud

TODO

Checklist

@edward-ly edward-ly requested a review from a team as a code owner September 18, 2025 22:59
@edward-ly edward-ly requested review from nfebe, sorbaugh and susnux and removed request for a team September 18, 2025 22:59
@susnux
Copy link
Contributor

susnux commented Sep 20, 2025

please always add the proper milestone and labels on PRs

@susnux susnux added this to the Nextcloud 33 milestone Sep 20, 2025
@susnux
Copy link
Contributor

susnux commented Sep 20, 2025

/backport to stable32

@susnux
Copy link
Contributor

susnux commented Sep 20, 2025

/backport to stable31

@susnux susnux requested review from Antreesy and CarlSchwan and removed request for sorbaugh September 20, 2025 10:46
@edward-ly
Copy link
Contributor Author

please always add the proper milestone and labels on PRs

Ah right, it's been a while since I made a server PR, thanks for the reminder. Although next time, I think it would be helpful to include those items in the checklist in the PR template. For neuro-accessibility reasons, required items should be explicitly rather than implicitly said.

This is a temporary fix that only applies while the server is still using
Vue 2.x (or `@nextcloud/vue` 8.x). Once migrated to Vue 3.x, this fix
may be reverted.

Signed-off-by: Edward Ly <contact@edward.ly>
@AndyScherzinger
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit 20a1be4 into master Sep 21, 2025
138 of 140 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/click-expand-comment branch September 21, 2025 16:28
@backportbot
Copy link

backportbot bot commented Sep 21, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/55179/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1b067aab 0e79e6f1

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55179/stable31

Error: Failed to push branch backport/55179/stable31: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@AndyScherzinger
Copy link
Member

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments not showing entire comment

7 participants