Skip to content

Fix(previews): prevent infinite loop in case of bad video file #54918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

Fix(previews): prevent infinite loop in case of bad video file #54918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/private/Preview/Movie.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ private function getSparseFile(File $file, int $size): string|false {
// size of the atom. Needed for large atoms like 'mdat' (the video data)
if ($atomSize === 1) {
$atomSize = (int)hexdec(bin2hex(stream_get_contents($content, 8, (int)($offset + 8))));
// 0 in the 64 bit field should not occur in a valid file, stop processing
if ($atomSize === 0) {
return false;
}
}
}
// Found the 'moov' atom, store its location and size
Expand Down Expand Up @@ -194,9 +198,9 @@ private function getSparseFile(File $file, int $size): string|false {
// Copy first $size bytes of video into new file
stream_copy_to_stream($content, $sparseFile, $size, 0);

// If 'moov' is located before $size in the video, it was already streamed,
// If 'moov' is located entirely before $size in the video, it was already streamed,
// so no need to download it again.
if ($moovOffset >= $size) {
if ($moovOffset + $moovSize >= $size) {
// Seek to where 'moov' atom needs to be placed
fseek($content, (int)$moovOffset);
fseek($sparseFile, (int)$moovOffset);
Expand Down
Loading