Skip to content

Conversation

@invario
Copy link
Contributor

@invario invario commented Sep 5, 2025

As noted by @Vislike (thanks!), prevent infinite looping if a video file is provided with invalid/improper atom data.
Also, fixed a calculation to ensure the moov atom is entirely contained within the downloaded data before skipping (previously only checked for the location of the beginning of the moov atom)

Signed-off-by: invario <67800603+invario@users.noreply.github.com>
@invario invario requested a review from a team as a code owner September 5, 2025 13:39
@invario invario requested review from Altahrim, ArtificialOwl and nfebe and removed request for a team September 5, 2025 13:39
@artonge artonge merged commit bfb5db8 into nextcloud:master Sep 8, 2025
394 of 403 checks passed
@invario invario deleted the fix-preview-sparse-file branch September 8, 2025 13:08
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants