Do not always check password checkbox when sharing without password #54538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
force-pushed
the
fix/54537/sharePasswordCheckboxCheckedByDefault
branch
from
e6086ee to
640b185
Compare
salmart-dev
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
susnux
approved these changes
Aug 23, 2025
The checkbox appears checked when no password is set (share.password === undefined) Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/54537/sharePasswordCheckboxCheckedByDefault
branch
from
640b185 to
eaaa907
Compare
salmart-dev
deleted the
fix/54537/sharePasswordCheckboxCheckedByDefault
branch
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/54538/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick eaaa9070
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/54538/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When sharing a file and navigating to the "Advanced settings" the "Set password" checkbox is set even though the password field is empty.
Default unselected:
Default selected and disabled:
Checklist