[Bug]: The "Set password" checkbox in external share has an incorrect default state #54537
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
When you make a new external share, the Set password checkbox is checked by default and you can't uncheck it until you input a char in the password textinput.
Steps to reproduce
- Go to admin share settings and uncheck the always ask for a password and the enforce password requirement configuration
- Create a new file
- Go to the share settings and share with an external email
- You can see the Set password input checked and you can't uncheck it
Expected behavior
The input must not be checked by default
Nextcloud Server version
31
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.3
Web server
Nginx
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Upgraded to a MAJOR version (ex. 31 to 32)
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
{
"system": {
"instanceid": "***REMOVED SENSITIVE VALUE***",
"passwordsalt": "***REMOVED SENSITIVE VALUE***",
"secret": "***REMOVED SENSITIVE VALUE***",
"trusted_domains": [
"adoc-web-t1.cg35.intra"
],
"datadirectory": "***REMOVED SENSITIVE VALUE***",
"overwrite.cli.url": "https:\/\/adoc-web-t1.cg35.intra",
"dbtype": "mysql",
"version": "31.0.8.1",
"dbname": "***REMOVED SENSITIVE VALUE***",
"dbhost": "***REMOVED SENSITIVE VALUE***",
"dbport": "",
"dbtableprefix": "oc_",
"dbuser": "***REMOVED SENSITIVE VALUE***",
"dbpassword": "***REMOVED SENSITIVE VALUE***",
"default_language": "fr",
"logtimezone": "UTC",
"log_rotate_size": 104857600,
"installed": true,
"maintenance": false,
"loglevel": 2,
"ldapIgnoreNamingRules": false,
"ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
"mail_smtpmode": "smtp",
"mail_from_address": "***REMOVED SENSITIVE VALUE***",
"mail_domain": "***REMOVED SENSITIVE VALUE***",
"mail_smtphost": "***REMOVED SENSITIVE VALUE***",
"mail_smtpport": "25",
"memcache.locking": "\\OC\\Memcache\\Redis",
"memcache.distributed": "\\OC\\Memcache\\Redis",
"memcache.local": "\\OC\\Memcache\\Redis",
"redis": {
"host": "***REMOVED SENSITIVE VALUE***",
"port": 6379,
"password": "***REMOVED SENSITIVE VALUE***"
},
"theme": "",
"lost_password_link": "disabled",
"updater.release.channel": "stable",
"mysql.utf8mb4": true,
"mail_sendmailmode": "smtp",
"simpleSignUpLink.shown": false,
"trashbin_retention_obligation": "20,90",
"trusted_proxies": "***REMOVED SENSITIVE VALUE***",
"forwarded_for_headers": [
"HTTP_X_FORWARDED_FOR"
],
"default_phone_region": "FX",
"htaccess.RewriteBase": "\/",
"twofactor_enforced": "true",
"twofactor_enforced_groups": [
"admin"
],
"twofactor_enforced_excluded_groups": [],
"maintenance_window_start": 100,
"app_install_overwrite": []
}
}List of activated Apps
Enabled:
- activity: 4.0.0
- app_api: 5.0.2
- cloud_federation_api: 1.14.0
- contacts: 7.2.5
- contactsinteraction: 1.12.0
- dav: 1.33.0
- federatedfilesharing: 1.21.0
- files: 2.3.1
- files_downloadlimit: 4.0.0
- files_external: 1.23.0
- files_pdfviewer: 4.0.0
- files_sharing: 1.23.1
- files_trashbin: 1.21.0
- files_versions: 1.24.0
- groupfolders: 19.1.3
- logreader: 4.0.0
- lookup_server_connector: 1.19.0
- notifications: 4.0.0
- oauth2: 1.19.1
- password_policy: 3.0.0
- photos: 4.0.0
- privacy: 3.0.0
- profile: 1.0.0
- provisioning_api: 1.21.0
- recommendations: 4.0.0
- related_resources: 2.0.0
- richdocuments: 8.7.4
- serverinfo: 3.0.0
- settings: 1.14.0
- sharebymail: 1.21.0
- theming: 2.6.1
- twofactor_backupcodes: 1.20.0
- twofactor_totp: 13.0.0-dev.0
- updatenotification: 1.21.0
- user_ldap: 1.22.0
- viewer: 4.0.0
- webhook_listeners: 1.2.0
- workflowengine: 2.13.0
Disabled:
- admin_audit: 1.21.0
- bruteforcesettings: 4.0.0 (installed 1.3.0)
- circles: 31.0.0 (installed 31.0.0)
- comments: 1.21.0 (installed 1.15.0)
- dashboard: 7.11.0 (installed 7.5.0)
- encryption: 2.19.0
- federation: 1.21.0 (installed 1.1.1)
- files_reminders: 1.4.0 (installed 1.0.0)
- firstrunwizard: 4.0.0 (installed 2.18.0)
- nextcloud_announcements: 3.0.0 (installed 1.5.0)
- spreed: 21.1.3 (installed 21.1.3)
- support: 3.0.0 (installed 1.0.0)
- survey_client: 3.0.0 (installed 0.1.5)
- suspicious_login: 9.0.1
- systemtags: 1.21.1 (installed 1.15.0)
- text: 5.0.0 (installed 3.10.1)
- twofactor_nextcloud_notification: 5.0.0
- user_status: 1.11.0 (installed 1.5.0)
- user_usage_report: 2.0.0 (installed 2.0.0)
- weather_status: 1.11.0 (installed 1.5.0)Nextcloud Signing status
No errors have been found.Nextcloud Logs
Additional info
For me the problem come from this line :
The init value for this.share.password is undefined, not empty string causing the wrong default state.