Skip to content

Conversation

@kesselb
Copy link
Collaborator

@kesselb kesselb commented Aug 12, 2025

Summary

The old version with files.view.index (with dir and scrollto) is opening the folder, but does not open the file or scroll to it.

The recommended way to reference a file is files.view.showFile as done by the files search provider and the activites app.

OCA\Comments\Search\LegacyProvider and OCA\Comments\Search\Result are deprecated since 20 and thus I took the opportunity to migrate away from it.

TODO

  • Check if the logic to obtain the comments was migrated correctly
  • Adding tests
  • Remove the deprecated and now unused classes right away
  • I assume we are loading the comments in a loop until 50 comments because there's no way, api wise, to obtain only comments with actor_type = users. If we are touching this anyway, then we should consider adding a new api for it to simplify the implementation and save database queries.

Checklist

@kesselb kesselb added 2. developing Work in progress bug labels Aug 12, 2025
@kesselb kesselb added this to the Nextcloud 32 milestone Aug 12, 2025
@kesselb kesselb self-assigned this Aug 12, 2025
The old version with files.view.index (with dir and scrollto) is opening
the folder, but does not open the file or scroll to it.

The recommended way to reference a file is files.view.showFile as done
by the files search provider and the activites app.

OCA\Comments\Search\LegacyProvider and OCA\Comments\Search\Result are
deprecated since 20 and thus I took the opportunity to migrate away from
it.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Opening a file from a comment search result does not open or scroll to the file

3 participants