fix(comments): use showFile route to reference files with a matching … #54826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
requested review from
Altahrim,
sorbaugh and
yemkareems
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
AndyScherzinger
approved these changes
Sep 3, 2025
…comment The files.view.index route with dir and scrollto is deprecated and opening the actual does not work anymore. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/54379/use-show-file-route-comment-search
branch
from
b883d39 to
a37ed05
Compare
provokateurin
approved these changes
Sep 3, 2025
provokateurin
deleted the
bug/54379/use-show-file-route-comment-search
branch
This was referenced Sep 3, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
use showFile route to reference files with a matching comment
The files.view.index route with dir and scrollto is deprecated, and opening the actual does not work anymore.
I had in mind to replace the deprecated APIs right away, but I dislike making such a large number of changes. I also came across some oddities in how pagination is implemented. Because of that, this PR is a simplified version of #54379 and should be much easier to backport.
Steps to reproduce: #54378
TODO
Checklist