[stable31] ignore missing theming app #52135
Conversation
ArtificialOwl
force-pushed
the
fix/52131/ignore-missing-themes-31
branch
from
d4b3522 to
01c9ecc
Compare
|
Also master? |
| $themesService = \OCP\Server::get(\OCA\Theming\Service\ThemesService::class); | ||
| $this->assign('enabledThemes', $themesService->getEnabledThemes()); | ||
| try { | ||
| $themesService = \OCP\Server::get(\OCA\Theming\Service\ThemesService::class); |
There was a problem hiding this comment.
How can this class not exist? theming is force enabled - always.
There was a problem hiding this comment.
it seems that it is not loaded during setup process
There was a problem hiding this comment.
Best would be to have e2e test for web setup (and also login flow...), most basic way would be to check if the setup page does not throw a 500 (before we install NC via occ)?
docker run --rm --volume .:/var/www/html -it ghcr.io/nextcloud/continuous-integration-php8.1:latest bash -c "(php -S 0.0.0.0:80 -t /var/www/html &) && curl --retry 5 --retry-connrefused -I localhost"
|
Also affects v30. |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to master |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
susnux
force-pushed
the
fix/52131/ignore-missing-themes-31
branch
from
98814cf to
46a3b18
Compare
|
The backport to # Switch to the target branch and update it
git checkout master
git pull origin master
# Create the new backport branch
git checkout -b backport/52135/master
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 46a3b18d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52135/masterError: Failed to check for changes with origin/master: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
fix #52131
regression: 00580b3