Skip to content

Conversation

@ChristophWurst
Copy link
Member

Summary

Emit events before and after running background jobs.

TODO

  • Implement
  • Test

Checklist

@ChristophWurst ChristophWurst added 2. developing Work in progress pending documentation This pull request needs an associated documentation update labels Mar 31, 2025
@ChristophWurst ChristophWurst self-assigned this Mar 31, 2025
@juliusknorr juliusknorr force-pushed the feat/cron/before-after-events branch from 8dbb5f0 to 3fed4f7 Compare April 8, 2025 05:56
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@juliusknorr juliusknorr force-pushed the feat/cron/before-after-events branch from 3fed4f7 to 69b6c28 Compare April 9, 2025 12:50
@juliusknorr
Copy link
Member

Tested and works for me as well 👍

Anything missing still before moving out of draft state @ChristophWurst ?

@ChristophWurst
Copy link
Member Author

I wasn't sure if including job arguments is needed or not, but that can be added later too

@ChristophWurst ChristophWurst marked this pull request as ready for review April 9, 2025 13:09
@ChristophWurst ChristophWurst requested a review from a team as a code owner April 9, 2025 13:09
@ChristophWurst ChristophWurst requested review from ArtificialOwl, nfebe and provokateurin and removed request for a team April 9, 2025 13:09
@ArtificialOwl
Copy link
Member

Tested and works for me as well 👍

Anything missing still before moving out of draft state @ChristophWurst ?

haven't tested, code looks good.

In case of doubt, we provided the NCU\ namespace for new public interface:
https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/api.html#php-unstable-api

@ChristophWurst
Copy link
Member Author

The API is forward-compatible for extension, we don't need the experimental namespace here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress pending documentation This pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants