fix: rework UploadFolder implementation #51010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
icewind1991
commented
Feb 24, 2025
icewind1991
commented
- use more dependency injection
- don't get the fileinfo for the upload folder multiple times
- get the upload folder fileinfo in a more efficient way
icewind1991
force-pushed
the
uploadfolder-rework
branch
from
f8764d5 to
413d73a
Compare
come-nc
approved these changes
Feb 25, 2025
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
uploadfolder-rework
branch
from
413d73a to
98af649
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
/backport! to stable29 |
2 tasks
|
/backport! to stable31 |
|
/backport! to stable30 |
2 tasks
2 tasks
icewind1991
requested review from
a team,
artonge and
yemkareems
and removed request for
a team
1 task
artonge
approved these changes
Apr 2, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.