[testing] Backport #51010 + #51839 #51918
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $userPrincipalBackend, | ||
| 'principals/users', | ||
| \OC::$server->query(CleanupService::class)); | ||
| \OC::$server->query(CleanupService::class), |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| $folder = $this->getUploadFolder(); | ||
| if (!$folder->isCreatable()) { | ||
| $user = $this->userSession->getUser(); | ||
| $this->logger->warning('Upload home not writable for ' . $user->getUID() . ', attempting to fix', ['permissions' => $folder->getPermissions()]); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
Signed-off-by: Robin Appelman <robin@icewind.nl> [skip ci]
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
backport/51010-51839/stable29
branch
from
19e5ad0 to
2c56dfb
Compare
|
Closing as stale and EOL branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing backport of #51010 and #51839