fix(ShareAPI): Send mails for mail shares by default

[nfebe]

Summary

It looks like, the frontend it needs to provide the sendMail param for the backend to decide whether mails would be sent.

Our UI does not have that at the moment so it should default to sending emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : #48012

Checklist

• Backports requested where applicable (ex: critical bugfixes)

[provokateurin]

Fix makes sense, curious how it broke though.

[nfebe]

/backport to stable30

[provokateurin]

Why rebase it so often?

[nfebe]

Why rebase it so often?

Some tests that seem unrelated (cypress especially are failing consistently)...

Re-basing triggers a rerun, but also adds the latest updates on master in case something that broke the tests has been resolved. (Because a bunch of other PRs are failing tests too)...

Now taking a closer to see if something is indeed broken.

[nfebe]

This breaks "File Requests"

server/apps/files_sharing/lib/Controller/ShareAPIController.php

Lines 721 to 727 in 363ba6b

	if (is_string($shareWith) && $shareType === IShare::TYPE_EMAIL) {
	// If sending a mail have been requested, validate the mail address
	if ($share->getMailSend() && !$this->mailer->validateMailAddress($shareWith)) {
	throw new OCSNotFoundException($this->l->t('Please specify a valid email address'));
	}
	$share->setSharedWith($shareWith);
	}

Why?

• File requests are sent with an empty string for shareWith which the backend uses to check if a shareWith value is available (poorly so)
• The file requests shareType is 4, which is mail share and I am not sure why that is.

[provokateurin]

Oops

[skjnldsv]

My fix would be to set the sendMail param to true by default, as file requests set it to false anyway 🤔

server/apps/files_sharing/lib/Controller/ShareAPIController.php

Line 568 in e089e40

?string $sendMail = null,

[nfebe]

My fix would be to set the sendMail param to true by default, as file requests set it to false anyway 🤔

and what about other things that use the API without specifying what goes to sendMail???

[nfebe]

/compile

[susnux]

and what about other things that use the API without specifying what goes to sendMail???

Agree, we can not change default behavior as this would be a breaking change.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)