Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_external): Handling in FTP UI for custom ports #47526

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Aug 27, 2024

Summary

Docs say we support this, but it is broken in the Web UI. We already handle the port parameter so let's use it properly.

$this->port = $params['port'] ?? 21;

TODO

  • Follow-up PR(s) pending any other backends with similar situations (i.e. SFTP)
  • Update doc sections for each backend

Checklist

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member Author

/backport to stable30

@joshtrichards
Copy link
Member Author

/backport to stable29

@solracsf solracsf added this to the Nextcloud 31 milestone Aug 27, 2024
@joshtrichards joshtrichards changed the title fix: custom port handling in UI for FTP External Storage fix(files_external): Handling in FTP UI for custom ports Sep 7, 2024
@joshtrichards joshtrichards merged commit 2480567 into master Sep 12, 2024
173 checks passed
@joshtrichards joshtrichards deleted the jtr/fix-ftp-custom-port-ui branch September 12, 2024 13:34
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants