Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(session): Log when session_* calls are slow #47105

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 7, 2024

Backport of PR #46106

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 7, 2024
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
9 tasks
@AndyScherzinger AndyScherzinger merged commit fe6e5fa into stable29 Aug 8, 2024
170 of 177 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/46106/stable29 branch August 8, 2024 08:28
@ArtificialOwl
Copy link
Member

I have a strange behavior when installing a fresh 29.0.5 (same with its rc1), but not on 30, and reverting this PR fixes the issue...

during the setup on the web interface with mysql, after the creation of the database, the migration steps are not done on the mysql but a sqlite file is generated. Meaning that no tables are created on the mysql, and the instance ends up with a 500 as the config.php is configured to run with mysql.

my first though was that the system config is lost when calling MigrationService

@artonge ? can you do some more test with a 29.0.5 patched to revert this PR, as you were also able to reproduce the issue on your side ?

@nickvergessen
Copy link
Member

And do you end up with a log files that has a slow session?

@artonge
Copy link
Contributor

artonge commented Aug 27, 2024

@ArtificialOwl I confirm that without this PR, the 29.0.5 installation works fine.

@ArtificialOwl
Copy link
Member

And do you end up with a log files that has a slow session?

No, log is pretty empty:

{
  "reqId": "N81UAnSq2tYZv6K7hNuZ",
  "level": 3,
  "time": "2024-08-27T10:14:49+00:00",
  "remoteAddr": "127.0.0.1",
  "user": "--",
  "app": "PHP",
  "method": "GET",
  "url": "/",
  "message": "fopen(/home/maxence/sites/nc29/nextcloud/config/config.php): Failed to open stream: No such file or directory at /home/maxence/sites/nc29/nextcloud/lib/private/Config.php#221",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:129.0) Gecko/20100101 Firefox/129.0",
  "version": "",
  "data": {
    "app": "PHP"
  }
}
{
  "reqId": "l215nn0eG2gnh464TUEt",
  "level": 2,
  "time": "2024-08-27T10:23:46+00:00",
  "remoteAddr": "127.0.0.1",
  "user": "--",
  "app": "no app in context",
  "method": "GET",
  "url": "/index.php/apps/files/preview-service-worker.js",
  "message": "Host nc29.local was not connected to because it violates local access rules",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:129.0) Gecko/20100101 Firefox/129.0",
  "version": "29.0.5.1",
  "data": []
}
{
  "reqId": "l215nn0eG2gnh464TUEt",
  "level": 2,
  "time": "2024-08-27T10:23:46+00:00",
  "remoteAddr": "127.0.0.1",
  "user": "--",
  "app": "no app in context",
  "method": "GET",
  "url": "/index.php/apps/files/preview-service-worker.js",
  "message": "Host nc29.local was not connected to because it violates local access rules",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:129.0) Gecko/20100101 Firefox/129.0",
  "version": "29.0.5.1",
  "data": []
}

@nickvergessen
Copy link
Member

Can you comment out:
https://github.com/nextcloud/server/pull/47105/files#diff-54c4c5113a473ed7e0e92e55a0d2183061aa584d8ded1ac46ba6529320a0670eR224-R239

TO see if the log of the slow session is causing it?

@ArtificialOwl
Copy link
Member

ArtificialOwl commented Aug 27, 2024

the issue seems to come when calling call logger() in https://github.com/nextcloud/server/pull/47105/files#diff-a7caddabaf7f36c861258dd85df0ef44d7d5f58851e534252be4cc7a7d842fa4R454 with value 'core'

If I filter the value 'core' in this condition https://github.com/nextcloud/server/blob/master/lib/public/Log/functions.php#L44, the installation process is fine

@ArtificialOwl
Copy link
Member

#47521

@joshtrichards
Copy link
Member

This showed up over the weekend with Docker installs: nextcloud/docker#2283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants